fix: Svelte popup swipeToClose default#4301
Open
Matthew-Kilpatrick wants to merge 1 commit intoframework7io:masterfrom
Open
fix: Svelte popup swipeToClose default#4301Matthew-Kilpatrick wants to merge 1 commit intoframework7io:masterfrom
Matthew-Kilpatrick wants to merge 1 commit intoframework7io:masterfrom
Conversation
The swipeToClose parameter of the Svelte Popup component previously defaulted to a value of `false`, while other parameters defaulted to `undefined`. As a result, the default `swipeToClose` value specified in the global app parameters was ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
swipeToCloseparameter of the Svelte Popup component previously defaulted to a value offalse, while other parameters defaulted toundefined. As a result, the defaultswipeToClosevalue specified in the global app parameters was ignored.This was causing problems for me in the context of routed modals - I have some routes configured with
options: {openIn: 'popup'}, however, there is currently no way when usingframework7-svelteto set these popups to allow theswipeToClosebehaviour.